Add shared library to build targets#285
Open
stlehmann wants to merge 6 commits intoBeckhoff:masterfrom
Open
Conversation
Member
|
@stlehmann unfortunately, its not so simple. This completely breaks the build for "-DUSE_TWINCAT_ROUTER". I try to fix that and I will squash most of your commits. especially the fixups. |
Member
|
@stlehmann please take a look at https://github.com/Beckhoff/ADS/tree/patrickbr/for-stlehmann-pyads-integration. Is that working for your usecase? The biggest problem with your original approach is that we have a more const correct API here in the standalone version, but when this is build with the original TwinCAT headers everything breaks as long as we use the same names for the exported C functions. EDIT: Do we need this? c08e11c |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves #284 by adding a shared library to the build targets. The compiled adslib.so is used by pyads, a thin Python wrapper for ADS.
The PR contains these changes: